Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh File buildall.sh: http://gerrit.cloudera.org:8080/#/c/11099/2/buildall.sh@473 PS2, Line 473: # Create .cdh file that contains the CDH_BUILD_NUMBER. If the content : # of the file is different than the one in the environment variable, : # append -U into IMPALA_MAVEN_OPTION to force Maven to update its local : # cache. : CDH_FILE="${IMPALA_HOME}/.cdh" : if [[ -f ${CDH_FILE} ]]; then : if [[ $(cat ${CDH_FILE}) != ${CDH_BUILD_NUMBER} ]]; then : export IMPALA_MAVEN_OPTIONS="${IMPALA_MAVEN_OPTIONS} -U" : fi : fi : echo "${CDH_BUILD_NUMBER}" > ${CDH_FILE} > Small thing: Move this above the "BUILD_FE_ONLY" block above. I'm thinking about this a bit. It's a bit of a weird case. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 2 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Thu, 02 Aug 2018 21:44:21 +0000 Gerrit-HasComments: Yes
