Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh File bin/clean.sh: http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh@81 PS1, Line 81: rm -rf ${IMPALA_HOME}/toolchain > We need to be careful here, because I think it is useful to be able to deve Removing toolchain/cdh_components is necessary to make sure the CDH components stay consistent with their Maven dependencies. For now, we can probably just delete toolchain/cdh_components and decide if in the future we need to also delete the whole toolchain directory? We can also push $CDH_BUILD_NUMBER into cdh_components but that may require more changes in other places. I'm okay either way though. mvn -U is something that Todd proposed in the mailing list that seems to work. It's pretty annoying that every time we bump the CDH_BUILD_NUMBER, we need to tell everyone to delete toolchain/cdh_components and run mvn -U to force the Maven cache and not to mention occasional build failures in Jenkins when the Maven cache isn't up-to-date. There's still another issue such as stale environment variables that we need to solve, but that's for another time I guess :) For development, I believe most people run their build with buildall.sh -noclean. So, the slow build shouldn't impact them. The changes should only impact when people do a clean build. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 18:19:06 +0000 Gerrit-HasComments: Yes
