Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/11099 )
Change subject: IMPALA-7381: Prevent build failure after switching to new CDH_BUILD_NUMBER ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh File bin/clean.sh: http://gerrit.cloudera.org:8080/#/c/11099/1/bin/clean.sh@81 PS1, Line 81: rm -rf ${IMPALA_HOME}/toolchain > Removing toolchain/cdh_components is necessary to make sure the CDH compone Thinking about this, one use case is to use a single Impala checkout and switch between branches. A developer can be working on the latest master branch with CDH_BUILD_NUMBER=X and then switch branches and work on a branch that hasn't been rebased with CDH_BUILD_NUBMER=X-1. Sometimes when switching branches, a clean build is the most reliable way to make sure things don't interfere with each other. A clean build is not always necessary, but when you need a clean build, there is usually no working around it. Downloading the entire toolchain is about 3165MB of network. Downloading CDH alone is about 1580MB of network. (This was a surprise to me.) If someone already has a working system and doesn't rebase, it would be nice to avoid extra network activity. I agree we need to do something so people don't need to manually handle CDH_BUILD_NUMBER changes. Is it difficult to only do these things only if the number changes? I think incorporating the CDH_BUILD_NUMBER into cdh_components would go a long way to helping, as that can avoid deleting the toolchain. It might be more complicated to detect when to do mvn -U. -- To view, visit http://gerrit.cloudera.org:8080/11099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0ad9c2258663d3bd7470e6df921041d1ca0c0be Gerrit-Change-Number: 11099 Gerrit-PatchSet: 1 Gerrit-Owner: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Wed, 01 Aug 2018 22:21:52 +0000 Gerrit-HasComments: Yes
