Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 1: (1 comment) As discussed, we usually use the same CR for subsequent patchsets since the reviewers can easily diff between revisions. Its ok for now though since the patch is small. http://gerrit.cloudera.org:8080/#/c/12296/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12296/1/tests/query_test/test_observability.py@429 PS1, Line 429: if re.search(" MemoryUsage", profile) is not None: This is non-deterministic because the query runs so fast that not a single sample is collected. So it is worth running some query which has fragment instances running for > sampling interval (=500ms). Also since this probably doesn't require a special test, how about moving this assert to after L400? I've checked that the query consistently produces some samples. (lineitem and orders are usually the biggest tables and there is a join + groupby) -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 1 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Jan 2019 19:15:19 +0000 Gerrit-HasComments: Yes
