Lars Volker has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/12296/4//COMMIT_MSG Commit Message: PS4: Please explain in the commit message why we make this change (consistency), that only time series counters are affected, and how you tested it. It would also be good to put a small subsection of a profile into the commit message that shows that after this change all counters are consistent. http://gerrit.cloudera.org:8080/#/c/12296/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/12296/4/be/src/util/runtime-profile.cc@777 PS4, Line 777: stream << prefix << " - " << v.first << "(" The amount of indent here looks different from the SummaryStatsCounters below, can you please double check that it's correct here? It also seems different from the plain counters in L1155. -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 10:35:19 +0000 Gerrit-HasComments: Yes
