Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 4: Code-Review+1 (2 comments) Lars, can you please do a +2 pass? http://gerrit.cloudera.org:8080/#/c/12296/4/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12296/4/tests/query_test/test_observability.py@403 PS4, Line 403: if re.search(" MemoryUsage", profile) is not None: not needed anymore. http://gerrit.cloudera.org:8080/#/c/12296/4/tests/query_test/test_observability.py@404 PS4, Line 404: MemoryUsage is a Time series counter, it should start with " - ", not " " nit: say something like "Time series counters should be prefixed with a hyphen" ? -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 4 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 02:43:37 +0000 Gerrit-HasComments: Yes
