Yongzhi Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/12296 )
Change subject: IMPALA-8093: Prefix time series counters with a hyphen ...................................................................... Patch Set 6: (3 comments) Patch set 6 should address all the issues. http://gerrit.cloudera.org:8080/#/c/12296/4//COMMIT_MSG Commit Message: PS4: > Please explain in the commit message why we make this change (consistency), Done http://gerrit.cloudera.org:8080/#/c/12296/4/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/12296/4/be/src/util/runtime-profile.cc@777 PS4, Line 777: stream << prefix << " - " << v.first << "(" > The amount of indent here looks different from the SummaryStatsCounters bel I used the same prefix as event timers above. Published new fix to make it the same as SummaryStatsCounter. http://gerrit.cloudera.org:8080/#/c/12296/1/tests/query_test/test_observability.py File tests/query_test/test_observability.py: http://gerrit.cloudera.org:8080/#/c/12296/1/tests/query_test/test_observability.py@429 PS1, Line 429: @classmethod > This is non-deterministic because the query runs so fast that not a single For this seq/snam/block format, this query can go into the if statement 100% with my local test. I used the test to setup the format to slow down the join to let the counter appear in the profile. And it is clearer to let more test works for a jira. -- To view, visit http://gerrit.cloudera.org:8080/12296 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2e3f08da765b3e6dedead45760729cbc5e8fb6fa Gerrit-Change-Number: 12296 Gerrit-PatchSet: 6 Gerrit-Owner: Yongzhi Chen <yc...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Yongzhi Chen <yc...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Feb 2019 17:10:34 +0000 Gerrit-HasComments: Yes
