Ethan Xue has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13313 )

Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config
......................................................................


Patch Set 7:

> Patch Set 7: Code-Review+1
>
> There's a rat check failure, you need to exclude good_impalarc2 in 
> https://github.com/apache/impala/blob/master/bin/rat_exclude_files.txt
>
> I'll let Bikramjeet to take another look at it for the +2.

Done. Added good_impalarc2 to rat_exclude_files.txt


--
To view, visit http://gerrit.cloudera.org:8080/13313
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816
Gerrit-Change-Number: 13313
Gerrit-PatchSet: 7
Gerrit-Owner: Ethan Xue <ethan....@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com>
Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Sat, 18 May 2019 00:07:35 +0000
Gerrit-HasComments: No

Reply via email to