Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/13313/8/shell/option_parser.py File shell/option_parser.py: http://gerrit.cloudera.org:8080/#/c/13313/8/shell/option_parser.py@288 PS8, Line 288: and option.help is not SUPPRESS_HELP: : # don't want to print default value for help or options : # without help text > remove the changes to this file, they are not relevant to the patch I agree that it's probably not relevant. However, it does fix a bug though. If an option is added to the parser with SUPPRESS_HELP, it would still show up in the help text, unless you add this additional check. Should I separate out this change to a separate patch? -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 8 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 20 May 2019 20:05:07 +0000 Gerrit-HasComments: Yes
