Ethan Xue has posted comments on this change. ( http://gerrit.cloudera.org:8080/13313 )
Change subject: IMPALA-6042: Allow Impala shell to use a global impalarc config ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/13313/8/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/13313/8/shell/impala_shell.py@1613 PS8, Line 1613: There are two types of options: shell options and query_options. Both can be set in the : command line, which override the options set in the user config file (~/.impalarc) and : the global config file (/etc/impalarc) > can you rephrase this and mention the order of precedence explicitly Done http://gerrit.cloudera.org:8080/#/c/13313/8/shell/impala_shell.py@1653 PS8, Line 1653: options defaults overwritten by those in config file > nit: update comment Done http://gerrit.cloudera.org:8080/#/c/13313/8/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/13313/8/tests/shell/test_shell_commandline.py@527 PS8, Line 527: assert 'DEFAULT_FILE_FORMAT: parquet' in result.stdout > can you also incorporate adding a change to the query options like this. So Done -- To view, visit http://gerrit.cloudera.org:8080/13313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a3179b6d9c9e3b2b01d6d3c5847cadb68782816 Gerrit-Change-Number: 13313 Gerrit-PatchSet: 8 Gerrit-Owner: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Ethan Xue <ethan....@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Mon, 20 May 2019 22:43:03 +0000 Gerrit-HasComments: Yes
