Qifan Chen has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/18093 )

Change subject: IMPALA-11033: Add support for specifying multiple executor 
group sets
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.cc
File be/src/scheduling/cluster-membership-mgr.cc:

http://gerrit.cloudera.org:8080/#/c/18093/2/be/src/scheduling/cluster-membership-mgr.cc@685
PS2, Line 685:  parsed_group_prefixes.insert(group_prefix);
> If we are planning to base the threshold on the resource pool configs then
I see.

The idea for FE to read the config will work well as long as all configs are 
updated in a short time window in which no compilations can take place.

Resolved.



--
To view, visit http://gerrit.cloudera.org:8080/18093
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684
Gerrit-Change-Number: 18093
Gerrit-PatchSet: 5
Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com>
Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 20 Dec 2021 19:59:36 +0000
Gerrit-HasComments: Yes

Reply via email to