Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 )
Change subject: IMPALA-11033: Add support for specifying multiple executor group sets ...................................................................... Patch Set 5: Code-Review+1 (3 comments) Thanks for the changes, looks good http://gerrit.cloudera.org:8080/#/c/18093/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18093/5//COMMIT_MSG@11 PS5, Line 11: size(the number of executors in each group). Every executor group Nit: need space after size http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc@622 PS5, Line 622: DCHECK(!prefix.empty() || exec_group_sets.size() == 1) Should this be DCHECK(!prefix.empty() || exec_group_sets.size() >= 1) ? http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.cc@629 PS5, Line 629: if (!it.second.IsHealthy()) continue; Is this interesting enough to warrant a log message? Or maybe as we did matching_exec_groups_found+ this will always just cause the WARNING message to be logged below? -- To view, visit http://gerrit.cloudera.org:8080/18093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684 Gerrit-Change-Number: 18093 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Tue, 21 Dec 2021 17:02:20 +0000 Gerrit-HasComments: Yes
