Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 )
Change subject: IMPALA-11033: Add support for specifying multiple executor group sets ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc File be/src/scheduling/cluster-membership-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@659 PS5, Line 659: EXPECT_EQ(update_req.exec_group_sets.size(), 1); : EXPECT_EQ(update_req.exec_group_sets[0].curr_num_executors, 1); : EXPECT_EQ(update_req.exec_group_sets[0].expected_num_executors, 20); : EXPECT_EQ(update_req.exec_group_sets[0].exec_group_name_prefix, ""); > not really. I think adding some extra assertions in this test is sufficient Those methods are part of ExecutorMembershipSnapshot which is a class in java and cannot be used here in a c++ unit test. http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr.h@222 PS5, Line 222: expected_exec_group_sets > In this patch we have two objects defined: TExecutorGroupSets and ExpectedE agreed, changing both to TExecutorGroupSets. to provide more context, my initial attempt for this patch had used TExecutorGroupSets in both places and the only reason i switched to using standard lib classes was to avoid including a larger header file (gen-cpp/Frontend_types.h) in cluster-membership-mgr.h since cluster-membership-mgr is itself included in a bunch of places and could potentially inflate build times -- To view, visit http://gerrit.cloudera.org:8080/18093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684 Gerrit-Change-Number: 18093 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Wed, 22 Dec 2021 21:14:28 +0000 Gerrit-HasComments: Yes
