Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/18093 )
Change subject: IMPALA-11033: Add support for specifying multiple executor group sets ...................................................................... Patch Set 5: Code-Review+1 (7 comments) Looks great! http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc File be/src/scheduling/cluster-membership-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@573 PS5, Line 573: first nit. Can we add 'group_set_name' and 'expected_size' to ExpectedExecGroupSets, instead of use first and second? http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@588 PS5, Line 588: // increasing order nit. of expected group size. http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@615 PS5, Line 615: 4 nit. duplicated case number (@587). http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@631 PS5, Line 631: Invalid input with no colon separator nit title is not right. http://gerrit.cloudera.org:8080/#/c/18093/5/be/src/scheduling/cluster-membership-mgr-test.cc@659 PS5, Line 659: EXPECT_EQ(update_req.exec_group_sets.size(), 1); : EXPECT_EQ(update_req.exec_group_sets[0].curr_num_executors, 1); : EXPECT_EQ(update_req.exec_group_sets[0].expected_num_executors, 20); : EXPECT_EQ(update_req.exec_group_sets[0].exec_group_name_prefix, ""); Can we add some assertions on methods numExecutors() and contains() for all test cases in this test? These methods are used by FE today. http://gerrit.cloudera.org:8080/#/c/18093/5/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java File fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java: http://gerrit.cloudera.org:8080/#/c/18093/5/fe/src/main/java/org/apache/impala/util/ExecutorMembershipSnapshot.java@97 PS5, Line 97: String host = address.getHostname(); Return false when exec_group_sets.size() > 0? http://gerrit.cloudera.org:8080/#/c/18093/5/fe/src/test/java/org/apache/impala/planner/ClusterSizeTest.java File fe/src/test/java/org/apache/impala/planner/ClusterSizeTest.java: http://gerrit.cloudera.org:8080/#/c/18093/5/fe/src/test/java/org/apache/impala/planner/ClusterSizeTest.java@61 PS5, Line 61: int num nit. Probably it is better to use two arguments (int expected_num_executors, int current_num_executors) for this method. -- To view, visit http://gerrit.cloudera.org:8080/18093 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9e0a3a5fe2b1f0b7507b7c096b7a3c373bc2e684 Gerrit-Change-Number: 18093 Gerrit-PatchSet: 5 Gerrit-Owner: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Bikramjeet Vig <bikramjeet....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Kurt Deschler <kdesc...@cloudera.com> Gerrit-Reviewer: Qifan Chen <qc...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Mon, 20 Dec 2021 22:54:10 +0000 Gerrit-HasComments: Yes
