Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19630 )
Change subject: IMPALA-8731: Balance queries across multiple executor groups ...................................................................... Patch Set 5: (6 comments) http://gerrit.cloudera.org:8080/#/c/19630/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19630/5//COMMIT_MSG@12 PS5, Line 12: '-balance_queries_across_executor_groups=true'. Please mention it's off by default http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2569 PS5, Line 2569: } add DCHECK with total_mem_limit - agg_effective_mem_reserved >= 0 and total_slots - agg_slots_in_use >= 0 http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2603 PS5, Line 2603: (mem_reserved, slots_in_use) available memory and slots in descending order http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2606 PS5, Line 2606: GetAvailableMemAndSlots(*a) > GetAvailableMemAndSlots(*b) For available memory and slots, which has high priority? Should we compare them separately? http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py@903 PS5, Line 903: coordinators and multiple executor groups mapped to the same resource pool.""" Could you add more detail for this test? http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py@906 PS5, Line 906: nit: indentation -- To view, visit http://gerrit.cloudera.org:8080/19630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25e851fb57c1d820c25cef5316f4ed800e4c6ac5 Gerrit-Change-Number: 19630 Gerrit-PatchSet: 5 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Fri, 24 Mar 2023 01:22:40 +0000 Gerrit-HasComments: Yes
