Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19630 )
Change subject: IMPALA-8731: Balance queries across multiple executor groups ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2569 PS5, Line 2569: } > add DCHECK with total_mem_limit - agg_effective_mem_reserved >= 0 and total Done http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2603 PS5, Line 2603: rom, matching_groups.end()); > available memory and slots in descending order Done http://gerrit.cloudera.org:8080/#/c/19630/5/be/src/scheduling/admission-controller.cc@2606 PS5, Line 2606: t admission to group with lower load first. > For available memory and slots, which has high priority? Should we compare I think memory has a high priority. In our clusters, we often see more queued queries with the reason 'Not enough memory available on host xxx'. http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py@903 PS5, Line 903: """Tests that the default admission control assign policy is filling up executor > Could you add more detail for this test? Done http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py@906 PS5, Line 906: sele > nit: indentation Done http://gerrit.cloudera.org:8080/#/c/19630/5/tests/custom_cluster/test_executor_groups.py@914 PS5, Line 914: fair_scheduler_allocation_path %s " > Can you add another test where if balance_queries_across_executor_groups=fa Done -- To view, visit http://gerrit.cloudera.org:8080/19630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25e851fb57c1d820c25cef5316f4ed800e4c6ac5 Gerrit-Change-Number: 19630 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Fri, 24 Mar 2023 13:45:19 +0000 Gerrit-HasComments: Yes
