Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19630 )
Change subject: IMPALA-8731: Balance queries across multiple executor groups ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/19630/7/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/19630/7/be/src/scheduling/admission-controller.cc@2606 PS7, Line 2606: it's the same we : // choose that with more available slots. nit: their available memory are same we choose the one with more available slots. http://gerrit.cloudera.org:8080/#/c/19630/7/tests/custom_cluster/test_executor_groups.py File tests/custom_cluster/test_executor_groups.py: http://gerrit.cloudera.org:8080/#/c/19630/7/tests/custom_cluster/test_executor_groups.py@905 PS7, Line 905: # A long running query that runs on every executor The steps of two new tests are not same. For second test, two queries are submitted from two coordinators and group2 is added after first query is started. Should we make them same for comparison? -- To view, visit http://gerrit.cloudera.org:8080/19630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I25e851fb57c1d820c25cef5316f4ed800e4c6ac5 Gerrit-Change-Number: 19630 Gerrit-PatchSet: 7 Gerrit-Owner: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Fri, 24 Mar 2023 19:50:28 +0000 Gerrit-HasComments: Yes
