Jim Apple has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/4878/1//COMMIT_MSG Commit Message: Line 14: The macro is only used in the buffer pool for now, but we can use it in I saw a JIRA you filed about this where you found a likely bug. Maybe reference that here? http://gerrit.cloudera.org:8080/#/c/4878/1/be/src/common/status.h File be/src/common/status.h: Line 262: #define STATUS_RETURN __attribute__((warn_unused_result)) Status How would you feel about making this a function-like macro, like MUST_USE(Type) __attribute__((warn_unused_result)) Type? PS1, Line 262: __attribute__((warn_unused_result)) This can be [[gnu::warn_unused_result]] with the new C++11 syntax -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-HasComments: Yes
