Jim Apple has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored ......................................................................
Patch Set 2: Code-Review+1 (2 comments) +1, not +2, because I'm interested in hearing Dan's thoughts on this as well. http://gerrit.cloudera.org:8080/#/c/4878/2//COMMIT_MSG Commit Message: PS2, Line 9: STATUS_RETURN MUST_USE now PS2, Line 10: __attribute__((warn_unused_result)) expands to [[gnu::warn_unused_result]] now -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
