Jim Apple has posted comments on this change. Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4878/2/be/src/bufferpool/buffer-allocator.h File be/src/bufferpool/buffer-allocator.h: PS2, Line 38: MUST_USE(Status) > This is going to get pretty noisy if we start tagging all return types like I would prefer MUST_USE(x) better as an API user, since I feel it gives me information about the type like const and volatile do. Unfortunately, it looks like warn_unused_result is a function attribute, not a type attribute: https://gcc.gnu.org/onlinedocs/gcc/Common-Function-Attributes.html#Common-Function-Attributes -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
