Tim Armstrong has uploaded a new patch set (#2). Change subject: IMPALA-3200 (buffer pool): warn if Status is ignored ......................................................................
IMPALA-3200 (buffer pool): warn if Status is ignored This introduces a STATUS_RETURN macro that expands to __attribute__((warn_unused_result)) Status. It can be used in function declarations in place of Status to issue warnings if a return Status is ignored. E.g. I found a bug IMPALA-4391 by applying it to some other places in the code. The macro is only used in the buffer pool for now, but we can use it in other places in follow-up patches if we agree on the pattern. Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc --- M be/src/bufferpool/buffer-allocator.h M be/src/bufferpool/buffer-pool.h M be/src/common/status.h 3 files changed, 16 insertions(+), 8 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/78/4878/2 -- To view, visit http://gerrit.cloudera.org:8080/4878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8c26e7532b5f2c7fe167accc73179e8b72b192bc Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com>
