Donghui Xu has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 7: (6 comments) Sorry. I'm not familiar with the use of git-clang-format tools.:) I have compiled and tested the newly added codes in my environment through the following cases: First, I set max_audit_event_log_files to 0 or 1, the check and rotation mechanism didn't work. Second, I set max_audit_event_log_files to 2, the check and rotation mechanism worked. I also have tested setting max_audit_event_log_files and max_log_files to different values, they all worked Correctly. The theck and rotation function LoggingSupport::DeleteOldLogs has been tested by unit test cases in be/src/util/Logging-support-test.cc. So No unit test cases need to be added. Would you tell me about your advice please? http://gerrit.cloudera.org:8080/#/c/4971/3/be/src/common/init.cc File be/src/common/init.cc: Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > Done Done Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > This still needs to be done. Done Line 69: "to retain. The most recent audit event log files are retained. If set to 0, " > Please follow the indentation of the surrounding code Done PS3, Line 69: . > nit: space missing Done http://gerrit.cloudera.org:8080/#/c/4971/6/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 271: /// Get the prefix of audit event log filename. > nit: dot. Done Line 272: static std::string GetAuditEventLogFilePrefix(); > Please remove trailing whitespace. Also check other files. Done -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
