Lars Volker has posted comments on this change. Change subject: IMPALA-4431: Add audit event log control mechanism to prevent disk overflow. ......................................................................
Patch Set 7: (3 comments) Only minor formatting issues left. Please see here for a description on how to use clang-format: https://cwiki.apache.org/confluence/display/IMPALA/Contributing+to+Impala It's a good tool to become familiar with. :) http://gerrit.cloudera.org:8080/#/c/4971/7//COMMIT_MSG Commit Message: Line 11: event log is enabled,the growing number of log files will fill up the nit: comma http://gerrit.cloudera.org:8080/#/c/4971/7/be/src/common/logging.cc File be/src/common/logging.cc: Line 17: #include "service/impala-server.h" Please move this to the block of impala includes, starting in L34. Please keep that block lexicographically sorted. Line 57: Please remove this new line. -- To view, visit http://gerrit.cloudera.org:8080/4971 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c3229cbdb6275f969c15258c9ccab6efeb24368 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Donghui Xu <davy...@163.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-HasComments: Yes
