Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 6: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/7064/6/be/src/service/impala-server.h File be/src/service/impala-server.h: PS6, Line 637: friend Status CheckProfileAccess(const std::string& user, For my understanding, why do we need this? http://gerrit.cloudera.org:8080/#/c/7064/4/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 162: private boolean enablePrivChecks_ = true; > That was my initial intention but the way it is used in PartitionSet.java m Got it, that's what I thought. We can reconsider the PartitionSet case later. http://gerrit.cloudera.org:8080/#/c/7064/6/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: Line 153: // If set, when privilege requests are registered they will use this error This only applies to masked priv requests right? Might want to clarify and/or even rename the var. -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
