Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 7: (2 comments) I am just answering two questions that Dan had. Let me know which approach you guys prefer. http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/client-request-state.h File be/src/service/client-request-state.h: Line 218: const ClientRequestState& request_state); > why can't this be a regular method on 'this'? That was my initial implementation. Alex suggested we move all the CheckProfileAccess functions in auth-util.[h|cc]. http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/impala-server.h File be/src/service/impala-server.h: Line 638: const QueryStateRecord& query_record); > same, why not regular method? Same comment as above. -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
