Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 6: (1 comment) Found a bug. Plz wait until I post a new patch before start reviewing it. http://gerrit.cloudera.org:8080/#/c/7064/6/be/src/service/impala-server.h File be/src/service/impala-server.h: PS6, Line 637: friend Status CheckProfileAccess(const std::string& user, > For my understanding, why do we need this? Because QueryStateRecord is private in ImpalaServer. In order for CheckProfileAccess function to access it it needs to be his friend :) -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
