Alex Behm has posted comments on this change. Change subject: IMPALA-4965: Authorize access to runtime profile and exec summary ......................................................................
Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/7064/7/be/src/service/client-request-state.h File be/src/service/client-request-state.h: Line 218: const ClientRequestState& request_state); > That was my initial implementation. Alex suggested we move all the CheckPro We need two implementations of CheckProfileAccess(), one that works against ClientRequestState and one against QueryStateRecord. Moving them to auth.h allows us to consolidate the code in one place. There are other ways of achieving the same thing, of course. -- To view, visit http://gerrit.cloudera.org:8080/7064 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2255d587367c2d328590ae8534a5406c4b0c9b15 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
