Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 6: Code-Review+1 (1 comment) Not sure if can +2 this given the change isn't trivial, so +1. Change LGTM. http://gerrit.cloudera.org:8080/#/c/7332/6/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: Line 138: format(role_name)) nit: Single line wherever applicable. -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes