Michael Brown has posted comments on this change. Change subject: IMPALA-5582: Store sentry privileges in lower case ......................................................................
Patch Set 6: (4 comments) None of these comments are must-dos, just things I've noticed. http://gerrit.cloudera.org:8080/#/c/7332/6/tests/authorization/test_grant_revoke.py File tests/authorization/test_grant_revoke.py: PS6, Line 104: db_name = "grant_rev_db_" + get_random_id(5) Why use a random suffix here but not in test_grant_revoke? PS6, Line 105: db_name_upper_case = "XDB_" + get_random_id(5) : db_name_mixed_case = "YdB_" + get_random_id(5) Maybe use TEST_GRANT_REVOKE and Test_GraNt_revoke or similar for prefixes? Line 138: format(role_name)) > nit: Single line wherever applicable. Yeah, most of these fit within 90 chars on 1 line. For the ones that don't, you can use this style, which is PEP-008 compliant: self.client.execute( "grant select on table {0}.test1 to {1}".format(db_name, role_name)) PS6, Line 195: result = self.client.execute("show tables in functional"); Not your change, but could you remove this semi-colon? -- To view, visit http://gerrit.cloudera.org:8080/7332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide3dfa601fcf77f5acc6adce9bea443aea600901 Gerrit-PatchSet: 6 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: anujphadke <apha...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: anujphadke <apha...@cloudera.com> Gerrit-HasComments: Yes
