Tim Armstrong has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 3: (1 comment) Could we add a basic test to run a couple of queries (including a DDL statement if that caused a crash earlier) and ping the backends page? I don't want to hold this up but it would be nice to avoid a similar bug creeping in again. http://gerrit.cloudera.org:8080/#/c/7711/3/be/src/runtime/coordinator-backend-state.cc File be/src/runtime/coordinator-backend-state.cc: PS3, Line 566: last_report_time_ms_ This function is inconsistent about whether it acquires 'lock_' when reading the fields - in some cases it goes through the public accessors (IsDone(), GetPeakConsumption(), etc) that acquire lock_ but in other case it is touching the fields directly. It's not a big deal but it's a bit confusing. It might be better to just grab 'lock_' in this function and get the fields directly. -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
