Tim Armstrong has posted comments on this change. Change subject: IMPALA-5811: Add 'backends' tab to query details pages ......................................................................
Patch Set 4: Code-Review+1 (1 comment) LGTM aside from one minor thing. Will give others a chance to look and +2 http://gerrit.cloudera.org:8080/#/c/7711/4/tests/webserver/test_web_pages.py File tests/webserver/test_web_pages.py: Line 183: assert len(response_json['backend_states']) == 3 This check is only accurate on the 3-node minicluster right - we probably need to skip the test if it's a local fs or remote cluster. -- To view, visit http://gerrit.cloudera.org:8080/7711 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib5b3b0fb8f4188da56da593199f41ce6fab99767 Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
