Yanlong Zheng has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set ......................................................................
Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237/6/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS6, Line 529: toString This change failed in test: TestRowResult.test I think the cause is that the string can be too long if append all data of a row. Could you please help to check the error message below? If it's true, I think there are two solutions: 1. only append key column, e.g. key int32 col1 = 123; 2. only append column name and type, e.g. int32 col1, int32 col2... If you think the 2nd is better, I can try to add a toString function in schema class, so operation can get the string there. Error information link: http://104.196.14.100/job/kudu-gerrit/5306/BUILD_TYPE=RELEASE/ Error message: Standard Error SLF4J: Failed toString() invocation on an object of type [org.apache.kudu.client.Insert] java.nio.BufferUnderflowException at java.nio.HeapByteBuffer.get(HeapByteBuffer.java:145) at java.nio.ByteBuffer.get(ByteBuffer.java:694) at org.apache.kudu.client.PartialRow.appendCellValueDebugString(PartialRow.java:668) at org.apache.kudu.client.PartialRow.stringifyRow(PartialRow.java:553) at org.apache.kudu.client.Operation.toString(Operation.java:206) at org.slf4j.helpers.MessageFormatter.safeObjectAppend(MessageFormatter.java:297) at org.slf4j.helpers.MessageFormatter.deeplyAppendParameter(MessageFormatter.java:269) at org.slf4j.helpers.MessageFormatter.arrayFormat(MessageFormatter.java:227) at org.slf4j.helpers.MessageFormatter.format(MessageFormatter.java:124) at org.slf4j.impl.Log4jLoggerAdapter.debug(Log4jLoggerAdapter.java:224) at org.apache.kudu.client.AsyncKuduClient$RetryRpcCB.call(AsyncKuduClient.java:745) at org.apache.kudu.client.AsyncKuduClient$RetryRpcCB.call(AsyncKuduClient.java:737) -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-HasComments: Yes
