Dan Burkert has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/5237/2/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: PS2, Line 596: { : return; : } > Currently we have two kinds of debug string: debug string and short debug s Hi Yanlong, I think the issue you ran into isn't that appendCellValueDebugString requires the column to be set, but instead that Operation.toString calls PartialRow.stringifyRowKey. I think instead, PartialRow should have a toString method which correctly handles including only the set columns (and which internally can call into appendCellValueDebugString). Then Operation can call that. -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-HasComments: Yes
