Dan Burkert has posted comments on this change. Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw exception when a column is not set ......................................................................
Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/5237/3/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: Line 523: please remove the trailing whitespace here and below. PS3, Line 529: toString > Sample Output: I think this information is better exposed through the schema, not necessarily through the PartialRow. I think a better format would look like the one done by 'appendDebugString', but only including the set columns in the row. So it would come out like '(STRING my_column="foo", INT32 other_column=99)'. You can go ahead and roll back the changes in appendCellValueDebugString. -- To view, visit http://gerrit.cloudera.org:8080/5237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yanlong Zheng <yan-long.zh...@outlook.com> Gerrit-HasComments: Yes
