Yanlong Zheng has posted comments on this change.

Change subject: KUDU-1757: fix appendCellValueDebugString, do not throw 
exception when a column is not set
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/5237/4/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java
File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java:

PS4, Line 529: toString
Sample output:
scala> kins.toString()
res3: String = KuduRpc(method=Write, tablet=29d98fc20fbe4c50b6bab98761da1698, 
attempt=0, DeadlineTracker(timeout=0, elapsed=16839), No traces) (int32 key=15, 
string value="test value 15")


PS4, Line 537: if (!columnsBitSet.get(idx)) {
             :         continue;
             :       }
Skip not set rows.


-- 
To view, visit http://gerrit.cloudera.org:8080/5237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ife05af5a11e95751b3cc259e786d36494aeb5d3a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Yanlong Zheng <yan-long.zh...@outlook.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Yanlong Zheng <yan-long.zh...@outlook.com>
Gerrit-HasComments: Yes

Reply via email to