Dan Burkert has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 90: echo "Outputting java 8 home" I agree with Adar's comment on rev 9 about removing or consolidating this to 1 line. PS12, Line 358: /opt/apache-maven-3.3.9/bin > Are we ready to migrate to the new maven to build everything Java? I tend to agree - just because we use JDK 8 to compile kudu-client and the rest doesn't mean they lose compatibility with JRE 7. The -target flag to javac & maven can ensure compat. Even moreso with bumping maven - as far as I know there aren't any hazards to packaging with maven 3.3 which would make the jar incompatible with maven 3.2 or below. -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
