Alexey Serbin has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/5492/12/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: PS12, Line 369: /opt/apache-maven-3.3.9/bin/mvn > would prefer not to hard-code any paths to maven here. Instead we should pr As I see it, this file should not be modified for the first iteration -- we discussed that with Adar and the proposed solution would be just build the kudu-jepsen module only for special profile -- that's to use in the script for the Jenkins job (that's already done). http://gerrit.cloudera.org:8080/#/c/5492/12/java/kudu-jepsen/resources/kudu.flags File java/kudu-jepsen/resources/kudu.flags: PS12, Line 2: --fromenv=rpc_bind_addresses : --fromenv=log_dir > hrm, why are these grabbed from the env? This is gone -- in the subsequent change I removed that: https://gerrit.cloudera.org/#/c/5500 http://gerrit.cloudera.org:8080/#/c/5492/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj: Line 17: ;; TODO allow to replace the binaries with locally built ones > is this fixed in a later patch in the series? definitely seems fairly impor That's done in my subsequent patch: https://gerrit.cloudera.org/#/c/5500 http://gerrit.cloudera.org:8080/#/c/5492/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu/nemesis.clj: Line 11: (defn replace-nodes > not really understading this function It seems like a hack to me too. As I understand, this is a hack to filter tablet server nodes from the array of all nodes (the latter contains master as well). I removed this hack in my subsequent patch (review item 5500). -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
