Alexey Serbin has posted comments on this change. Change subject: Kudu Jepsen Tests - Initial Commit ......................................................................
Patch Set 12: (1 comment) BTW, what would be the best way to update this patch given the fact there are subsequent ones? I would suggest to fix only issues which are not addressed in the subsequent patches. Does it sound reasonable? http://gerrit.cloudera.org:8080/#/c/5492/12/java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj File java/kudu-jepsen/src/main/clojure/jepsen/kudu.clj: PS12, Line 123: (meh (->> (c/exec :service :kudu-master :stop))) : (meh (->> (c/exec :rm :-rf "/var/lib/kudu/master")))) : : (when (.contains (:tservers test) node) : (info node "Stopping Kudu Tablet Server") : (meh (->> (c/exec :service :kudu-tserver :stop))) : (meh (->> (c/exec :rm :-rf "/var/lib/kudu/tserver"))))) > src/main/clojure/jepsen/kudu.clj:123:16: suspicious-expression: ->> called The suspect is gone in the subsequent patch (review item 5500). -- To view, visit http://gerrit.cloudera.org:8080/5492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I590c6e78840304b3131666c7037ff9a08dc77dea Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
