Hello Dan Burkert, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5804
to review the following change.
Change subject: Reduce default RSA key length for tests
......................................................................
Reduce default RSA key length for tests
The default RSA key length for real servers is set to 2048 bits.
However, generating a 2048-bit RSA key is relatively expensive. Since we
do it on every server start, and our tests start thousands of servers,
this has a negative impact on test time.
This changes the default in ExternalMiniCluster and in our own tests to
512-bit keys, which appear to be about 16x faster to generate compared
to 2048-bit keys (based on 'perf stat -r50 openssl genrsa -out /tmp/r
<key length>').
I measured the improvement on registration-test from ~4000ms to ~1200ms
wall time on my laptop.
This also changes the way we override flags for tests to use the gflags
API instead of directly setting FLAGS_* variables. This cleans up some
workarounds we did previously and also allows us to set flags which
might not apply for all test cases (eg security flags aren't in util
tests).
Change-Id: I310ac762aff4fed891a0491b2c3249e0faa9375f
---
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/util/flag_tags-test.cc
M src/kudu/util/flags-test.cc
M src/kudu/util/test_util.cc
4 files changed, 27 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/5804/1
--
To view, visit http://gerrit.cloudera.org:8080/5804
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I310ac762aff4fed891a0491b2c3249e0faa9375f
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Dan Burkert <[email protected]>
