Alexey Serbin has posted comments on this change. Change subject: Reduce default RSA key length for tests ......................................................................
Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/5804/1//COMMIT_MSG Commit Message: PS1, Line 22: This also changes the way we override flags for tests to use the gflags : API instead of directly setting FLAGS_* variables. This cleans up some : workarounds we did previously and also allows us to set flags which : might not apply for all test cases (eg security flags aren't in util : tests). nit: consider putting this part of the patch into a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/5804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310ac762aff4fed891a0491b2c3249e0faa9375f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
