Adar Dembo has posted comments on this change. Change subject: Reduce default RSA key length for tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5804/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS1, Line 79: // We don't check for errors here, because we have some default flags that : // only apply to certain tests. Hmm, but doesn't that mean that if one of these flags is renamed or removed, we'll never know to update this code? Seems risky. -- To view, visit http://gerrit.cloudera.org:8080/5804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310ac762aff4fed891a0491b2c3249e0faa9375f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
