Todd Lipcon has posted comments on this change. Change subject: Reduce default RSA key length for tests ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5804/1/src/kudu/util/test_util.cc File src/kudu/util/test_util.cc: PS1, Line 79: // We don't check for errors here, because we have some default flags that : // only apply to certain tests. > What if we called GetCommandLineFlagInfoOrDie() on each one beforehand, to Exactly the latter - that's the reason for this change in the first place. eg any test in util doesn't depend on 'security' and thus won't have those flags. We only got lucky before in that the original two flags were in util -- To view, visit http://gerrit.cloudera.org:8080/5804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I310ac762aff4fed891a0491b2c3249e0faa9375f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
