Todd Lipcon has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/5992/4/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: PS4, Line 75: if (!CRYPTO_THREADID_get_callback()) { : return Status::RuntimeError("Thread-ID callback not initialized"); : } > Does this need to be a requirement? Impala relies on thrift to initialize S ah, you're right.. it looks like this has been the case for all of the OpenSSL >= 1.0.0, and that's our minimum version. Let me check with Dan and Alexey to see what they think, but I think you're probably right that we can stop setting and checking the threadid callback. -- To view, visit http://gerrit.cloudera.org:8080/5992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43eab5c848b30362356422d0380a336f16587562 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
