Alexey Serbin has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5992/6/src/kudu/client/client.h File src/kudu/client/client.h: PS6, Line 154: NOTE doxygen nit: please use @note instead to enable special formatting in the generated docs. http://gerrit.cloudera.org:8080/#/c/5992/6/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: PS6, Line 80: return; Is it worth adding LOG() statement to inform on this control path branch? Consider at least LOG(INFO) Line 130: g_disable_ssl_init = true; Consider adding LOG(INFO) about disabling OpenSSL initialization. -- To view, visit http://gerrit.cloudera.org:8080/5992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43eab5c848b30362356422d0380a336f16587562 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
