Sailesh Mukil has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/5992/5/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: PS5, Line 88: SSL_CTX* ctx = SSL_CTX_new(SSLv23_method()); Call CheckOpenSSLInitialized() instead? Line 94: // Continue anyway rather than crashing the process in release builds. Why not do something similar to what DoSaslInit() does here? i.e. if SSL already set up, set g_disable_ssl_init = true; And if (g_disable_ssl_init) { check SSLMutexImplementationProvided(); check locking_callback(); return; } Instead of overwriting everything? -- To view, visit http://gerrit.cloudera.org:8080/5992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43eab5c848b30362356422d0380a336f16587562 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
