Dan Burkert has posted comments on this change. Change subject: KUDU-1738. Allow users of the client to disable OpenSSL initialization ......................................................................
Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/5992/6/src/kudu/security/openssl_util.cc File src/kudu/security/openssl_util.cc: Line 46: bool g_ssl_is_initialized = false; Could you add some notes on the thread safety of these booleans? My first reaction is that they don't look protected. Line 70: SSL_CTX* ctx = SSL_CTX_new(SSLv23_method()); This would be simpler as auto ctx = ssl_make_unique(SSLv23_method()); using the helpers from openssl_utils. Line 88: SSL_CTX* ctx = SSL_CTX_new(SSLv23_method()); Same. -- To view, visit http://gerrit.cloudera.org:8080/5992 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I43eab5c848b30362356422d0380a336f16587562 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Jordan Birdsell <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
