Dan Burkert has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() ......................................................................
Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.h File src/kudu/security/tls_socket.h: Line 35: // If the result is an error then the value in nwritten is not valid. Could you instead add these docs to the parent class in socket.h, they should apply equally to all implementations. Line 44: // iov[nwritten] to iov[iov_len-1] need to be written again. The nwritten index isn't valid on the iov array. I'd just simplify and say '..., but not all the bytes were written, the unwritten bytes must be retried. See writev(2) for more information.'. -- To view, visit http://gerrit.cloudera.org:8080/7141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
