Adar Dembo has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() ......................................................................
Patch Set 5: (3 comments) Fix looks fine, just have some suggestions around commenting. http://gerrit.cloudera.org:8080/#/c/7141/5/src/kudu/security/tls_socket.cc File src/kudu/security/tls_socket.cc: Line 80: // Don't want to update the number written if there was an error. To be honest I don't think this comment is necessary either; the "Status s = Foo(); if (!s.ok()) break;" idiom is common enough that it doesn't need explaining. Line 81: // We don't return yet, since we want to turn off the Tcp Cork. This comment duplicates the one on L78. http://gerrit.cloudera.org:8080/#/c/7141/5/src/kudu/util/net/socket.h File src/kudu/util/net/socket.h: Line 124: // If amt == nwritten == 0, this is a no-op. Don't you mean "this was a no-op"? That is, if nwritten == 0 after the call? Why would it matter what nwritten was before the call? -- To view, visit http://gerrit.cloudera.org:8080/7141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
