Edward Fancher has posted comments on this change. Change subject: Undefined behavior in TlsSocket::Writev() ......................................................................
Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/7141/4/src/kudu/security/tls_socket.h File src/kudu/security/tls_socket.h: Line 35: Status Write(const uint8_t *buf, int32_t amt, int32_t *nwritten) override WARN_UNUSED_RESULT; > Could you instead add these docs to the parent class in socket.h, they shou Done Line 44: > The nwritten index isn't valid on the iov array. I'd just simplify and say Done -- To view, visit http://gerrit.cloudera.org:8080/7141 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia5b5bbb3fd2ec8fcd1a48873446f3aa09546eaac Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Edward Fancher <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-HasComments: Yes
