Todd Lipcon has posted comments on this change. Change subject: WIP: use C++ ExternalMiniCluster for Java and Python tests ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7853/2//COMMIT_MSG Commit Message: PS2, Line 47: WIP because, well, it should be pretty obvious. I was able to get through a : full run of "mvn verify" locally, so I have confidence that this can work. : But I'd like to solicit feedback on the general approach before spending : more time applying spit and polish. general approach seems reasonable to me. The only concern/question I have is about the formatting and compatibility requirements of the CLI requests/responses. Using something like protobuf or JSON would make it easier to ensure that the commands are extensible, potentially self-documenting, and machine parseable. On the other hand, protobuf at least would require more dependencies to be used in the embedding languages. Given we have protobuf to/from-JSON support, maybe we could use protobuf to "define" the API, but use JSON to serialize it? Then we don't need to worry about parsing and generation and random things like "what if the minicluster base dir path has a space in it", etc. -- To view, visit http://gerrit.cloudera.org:8080/7853 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0e693921ef780dc4a06e536c6b7408f7f0b252f6 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
